Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added padding for non-tile multiple channels #18595

Closed
wants to merge 1 commit into from

Conversation

skrsticTT
Copy link
Contributor

Ticket

#18198

Problem description

Some maxpool width sharded tests fail on blackhole because they had non-tile multiple width per shard.

What's changed

Shard is padded to tile multiple in those cases. Also that is applied in cases where shard width is greater than 32, because case when shard is 16 is still valid. Values less than 32 and not equal to 16 are invalid and assert will be triggered.

Checklist

@skrsticTT skrsticTT self-assigned this Mar 4, 2025
@skrsticTT skrsticTT requested a review from a team as a code owner March 4, 2025 13:11
@skrsticTT
Copy link
Contributor Author

Closing this PR because alternative solution is in #18601

@skrsticTT skrsticTT closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant